Fix controller problematic log output #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
added
the
kind/changelog-not-required
qiuming-best
force-pushed
the
controller-log-fix
branch
from
09c85de to
bb12914
Compare
blackpiglet
added
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## release-1.9 #5570 +/- ##
===============================================
- Coverage 41.67% 41.66% -0.02%
===============================================
Files 214 214
Lines 18594 18599 +5
===============================================
Hits 7749 7749
- Misses 10262 10267 +5
Partials 583 583
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anshulahuja98
requested changes
Nov 9, 2022
| @@ -14,6 +14,7 @@ https://velero.io/docs/v1.9/ | |||
| https://velero.io/docs/v1.9/upgrade-to-1.9/ | |||
|
|
|||
| ### All changes | |||
| * Fix controller problematic log output (#5570, @qiuming-best) | |||
There was a problem hiding this comment.
Also upgrade controller runtime to 0.12.2
Signed-off-by: Ming <[email protected]>
qiuming-best
force-pushed
the
controller-log-fix
branch
from
bb12914 to
d1ead7a
Compare
github-actions
bot
added
the
Dependencies
Lyndon-Li
approved these changes
Nov 9, 2022
blackpiglet
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
fix #5571
for problem one
As 1.9.3 we've upgrade
sigs.k8s.io/controller-runtimelibrary fromv0.10.2tov0.12.1, the library changed the direct output object tofmt.Sprintfformat object way, our PeriodicalEnqueueSource struct need to provide an implementation ofStringfunction or there would be messy output about it.for problem two
we need upgrade
sigs.k8s.io/controller-runtimetov0.12.2,Relevant fix in controller runtime: kubernetes-sigs/controller-runtime#1907Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.